Re: [PATCH libvirt-tck] bhyve: reconnect to domains after libvirtd restart

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



  Ján Tomko wrote:

> On 06/29/2014 06:06 PM, Roman Bogorodskiy wrote:
> > Try to reconnect to the running domains after libvirtd restart. To
> > achieve that, do:

...

> > @@ -1207,9 +1218,16 @@ bhyveStateInitialize(bool priveleged ATTRIBUTE_UNUSED,
> >                                         NULL, NULL) < 0)
> >          goto cleanup;
> >  
> > +    conn = virConnectOpen("bhyve:///system");
> 
> The connection does not seem to be used anywhere.
> 
> QEMU driver uses it for:
> qemuTranslateDiskSourcePool
> qemuProcessFiltersInstantiate
> qemuProcessRecoverJob
> 
> Neither of which is done in the bhyve driver.
> 
> ACK with the conn removed.

Removed 'conn' and pushed; thanks!

Roman Bogorodskiy

Attachment: pgpxOVdgqjuFD.pgp
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]