Re: [PATCH v3 08/16] conf, schema: add support for memnode elements

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 16, 2014 at 12:21:24PM -0600, Eric Blake wrote:
On 07/16/2014 08:42 AM, Martin Kletzander wrote:
Signed-off-by: Martin Kletzander <mkletzan@xxxxxxxxxx>
---
[...]
+++ b/docs/schemas/domaincommon.rng
@@ -789,6 +789,23 @@
               </choice>
         </element>
       </optional>
+      <zeroOrMore>
+        <element name="memnode">
+          <attribute name="cellid">
+            <ref name="unsignedInt"/>
+          </attribute>
+          <attribute name="mode">
+            <choice>
+              <value>strict</value>
+              <value>preferred</value>
+              <value>interleave</value>
+            </choice>
+          </attribute>
+          <attribute name='nodeset'>
+            <ref name='cpuset'/>
+          </attribute>
+        </element>
+      </zeroOrMore>
     </element>

Missing an <interleave> here (<memory> and <memnode> should be swappable
with one another).


Oh!  My bad.  So sorry :-(

Good point, is this OK to push as trivial (git diff -w):

diff --git i/docs/schemas/domaincommon.rng w/docs/schemas/domaincommon.rng
index a0ea300..fb5bdb3 100644
--- i/docs/schemas/domaincommon.rng
+++ w/docs/schemas/domaincommon.rng
@@ -790,6 +790,7 @@
        </element>
      </optional>
      <zeroOrMore>
+        <interleave>
          <element name="memnode">
            <attribute name="cellid">
              <ref name="unsignedInt"/>
@@ -805,6 +806,7 @@
              <ref name='cpuset'/>
            </attribute>
          </element>
+        </interleave>
      </zeroOrMore>
    </element>
  </define>
--

Martin

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]