On 07/16/2014 08:42 AM, Martin Kletzander wrote: > In XML format, by definition, order of fields should not matter, so > order of parsing the elements doesn't affect the end result. When > specifying guest NUMA cells, we depend only on the order of the 'cell' > elements. With this patch all older domain XMLs are parsed as before, > but with the 'id' attribute they are parsed and formatted according to > that field. This will be useful when we have tuning settings for > particular guest NUMA node. It's not always true that order doesn't matter - for the longest time, the order of <disk> under <devices> determined boot order. But I agree that the flexibility of using an id to allow arbitrary ordering can be nicer than enforcing constant ordering. > > Signed-off-by: Martin Kletzander <mkletzan@xxxxxxxxxx> > --- > docs/formatdomain.html.in | 17 +++++---- > docs/schemas/domaincommon.rng | 5 +++ Looks okay to me on the schema side. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list