On 07/15/2014 04:41 AM, Ján Tomko wrote: >> >> Is it just a matter of coming up with a better name? Maybe: >> >> VIR_TRISTATE_ABSENT = 0, >> VIR_TRISTATE_NO, >> VIR_TRISTATE_YES, > > Without the DOMAIN prefix, this could be used for network_conf.c too. > How about: > VIR_TRISTATE_SWITCH_ABSENT = 0, > VIR_TRISTATE_SWITCH_OFF > VIR_TRISTATE_SWITCH_ON > > for the other enum? (And maybe VIR_TRISTATE_BOOL for the first one?) Yes, that seems reasonable as well. Looking forward to the v2. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list