On 07/15/2014 02:35 AM, Peter Krempa wrote: > 4cc1f1a01fb338de939ba88eb933931687b22336 introduced a crash when doing a > block copy as virStorageSourceInitChainElement was called on > "disk->mirror" that is still NULL at that point instead of "mirror" > which temporarily holds the mirror source struct until it's fully > initialized. This resulted into a crash as a NULL was dereferenced. > > Reported by: Shanzi Yu <shyu@xxxxxxxxxx> > --- > > Fortunately unreleased. > > src/qemu/qemu_driver.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > ACK > diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c > index 8d40bc9..c0ad446 100644 > --- a/src/qemu/qemu_driver.c > +++ b/src/qemu/qemu_driver.c > @@ -15309,7 +15309,7 @@ qemuDomainBlockCopy(virDomainObjPtr vm, > if (VIR_STRDUP(mirror->path, dest) < 0) > goto endjob; > > - if (virStorageSourceInitChainElement(disk->mirror, disk->src, false) < 0) > + if (virStorageSourceInitChainElement(mirror, disk->src, false) < 0) > goto endjob; > > if (qemuDomainPrepareDiskChainElement(driver, vm, mirror, > -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list