Re: [PATCH] virseclabel: Resolve Coverity FORWARD_NULL issue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/11/2014 07:42 AM, John Ferlan wrote:
> Resolve issue introduced by commit id '13adf1b'
> 
> Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx>
> ---
>  src/util/virseclabel.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

ACK

> 
> diff --git a/src/util/virseclabel.c b/src/util/virseclabel.c
> index e9d973c..02a8342 100644
> --- a/src/util/virseclabel.c
> +++ b/src/util/virseclabel.c
> @@ -61,7 +61,7 @@ virSecurityLabelDefNew(const char *model)
>      if (VIR_ALLOC(seclabel) < 0 ||
>          VIR_STRDUP(seclabel->model, model) < 0) {
>          virSecurityLabelDefFree(seclabel);
> -        seclabel = NULL;
> +        return NULL;
>      }
>  
>      seclabel->relabel = true;
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]