On 11.07.2014 13:07, Michele Paolino wrote:
On 10/07/2014 18:01, Michal Privoznik wrote:
On 02.07.2014 15:20, Michele Paolino wrote:
This patch adds the test files and the documentation for vhost-user.
Signed-off-by: Michele Paolino <m.paolino@xxxxxxxxxxxxxxxxxxxxxx>
---
docs/formatdomain.html.in | 34
+++++++++++++++++++
docs/schemas/domaincommon.rng | 39
++++++++++++++++++++++
.../qemuxml2argv-net-vhostuser.args | 7 ++++
.../qemuxml2argv-net-vhostuser.xml | 33
++++++++++++++++++
tests/qemuxml2argvtest.c | 1 +
tests/qemuxml2xmltest.c | 1 +
6 files changed, 115 insertions(+)
create mode 100644
tests/qemuxml2argvdata/qemuxml2argv-net-vhostuser.args
create mode 100644
tests/qemuxml2argvdata/qemuxml2argv-net-vhostuser.xml
diff --git a/docs/schemas/domaincommon.rng
b/docs/schemas/domaincommon.rng
index af51eee..f85dd61 100644
--- a/docs/schemas/domaincommon.rng
+++ b/docs/schemas/domaincommon.rng
@@ -1968,6 +1968,45 @@
</group>
<group>
<attribute name="type">
+ <value>vhostuser</value>
+ </attribute>
+ <interleave>
+ <optional>
+ <element name="source">
I wouldn't say <source/> is optional in case of <interface
type='vhostnet'/>. It contains crucial information that helps us
construct the correct qemu command line which would not be possible
otherwise.
I agree, but the schemas of the other interfaces it's the same. Please
see the Laine's comment at
http://www.redhat.com/archives/libvir-list/2014-June/msg00279.html
Well, not for all other interface types. Moreover, currently the your
patches require <source/>. But I can live with schema wider than our parser.
Michal
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list