Re: [PATCH v2] LXC: add support for --config in setmem command

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Ján Tomko [mailto:jtomko@xxxxxxxxxx]
> Sent: Thursday, July 10, 2014 9:40 PM
> >
> > -    if (virDomainSetMemoryEnsureACL(dom->conn, vm->def) < 0)
> > +    if (virDomainSetMemoryFlagsEnsureACL(dom->conn, vm->def, flags) < 0)
> > +        goto cleanup;
> > +
> > +    if (!(caps = virLXCDriverGetCapabilities(driver, false)))
> > +        goto cleanup;
> > +
> > +    if (virDomainLiveConfigHelperMethod(caps, driver->xmlopt, vm, &flags,
> > +                                        &persistentDef) < 0)
> >          goto cleanup;
> >
> 
> >      if (newmem > vm->def->mem.max_balloon) {
> 
> This check should only be done for AFFECT_LIVE.
> For AFFECT_CONFIG it needs to be checked against the max_balloon value from
> the persistent definition.
> 
Oops, my fault.
Thanks for your comments

- Chen


--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list





[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]