Re: [PATCH v2 3/4] conf: Always format seclabel's model

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/10/2014 04:04 PM, Michal Privoznik wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1113860
> 
> We've always done that. Well, until 990e46c45. Point is, if we don't
> format model, we may lose a domain on libvirtd restart. If the
> seclabel is implicit however, we should skip it's formatting.
> 

It seems we only generate a seclabel with model="none" with type="none".
Specifying other types (or the relabel attribute) with model="none" doesn't
make much sense.

Could we instead error out on other types than "none" when model is "none", or
(if we can't) silently correct it to type "none"?

Also, formatting model="none" in the status XML shouldn't be needed after that
since we only generate it with type="none" and we would reject other types.

Jan

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]