> > > > "attach-disk" does not give an error, > > > > when the domain which is attached has already used the source which attach. > > > > This has danger of the data corruption. > > > > > > > > I make the patch to add the check of this. > > > > This patch outputs an error, > > > > when the domain which is attached has already used the source which attach. > > > > > > What hypervisor were you testing with ? AFAIR, XenD should already raise > > > an appropriate error in this scenario. > > > > > XenD Don't check this > > when I confirm it in xen(cs 18756:5fd51e1e9c79). > > > > Therefore, > > I think that it had better add check to virsh.c, > > because this should be checked whether xen or qemu. > > No, because then the check is only performed for people using virsh, and > would have to be duplicated across every single other application using > libvirt. If it is done in the XenD or libvirtd at time of use, then all > users of libvirt are automatically protected. Of course, it is the best if it guarded in Xend. But, the user may be not protected depending on cs of xen, Had better it attach check-method in libvirt.c to protect all users of libvirt ? Thanks, Shigeki Sakamoto. -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list