Jim Meyering wrote: > Chris Lalancette <clalance@xxxxxxxxxx> wrote: >> Actually, the subject isn't strictly true. Libvirt CVS currently fails to build >> when using this configuration on any platform: >> >> ./configure --build=i686-redhat-linux-gnu --host=i686-redhat-linux-gnu >> --target=i386-redhat-linux-gnu --program-prefix= --prefix=/usr >> --exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin --sysconfdir=/etc >> --datadir=/usr/share --includedir=/usr/include --libdir=/usr/lib >> --libexecdir=/usr/libexec --localstatedir=/var --sharedstatedir=/usr/com >> --mandir=/usr/share/man --infodir=/usr/share/info --without-xen --without-qemu >> --with-init-script=redhat --with-qemud-pid-file=/var/run/libvirt_qemud.pid >> --with-remote-file=/var/run/libvirtd.pid >> >> (the important part is the --without-xen --without-qemu in there). This just >> happens to be the configuration that koji uses when it is building the ppc >> libvirt package. There are a lot of build errors, but they start with: >> >> network_driver.c:64: error: expected specifier-qualifier-list before >> 'iptablesContext' >> network_driver.c: In function 'networkStartup': >> network_driver.c:124: error: 'struct network_driver' has no member named 'logDir' >> >> This seems to stem from the new module refactoring. I'm not entirely sure >> what's the correct way to fix it, however; I *think* we always want to build the >> network_driver at this point, but if that's the case, then we need to make sure >> we have the header files for iptablesContext and friends included. Dan, any ideas? > > Hi Chris, > > FYI, this patch fixes it. > The result builds both on rawhide and for mingw. Yep, fixes it here too. Thanks. Assuming danpb is OK with this, we should push it. -- Chris Lalancette -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list