On Wed, Nov 05, 2008 at 10:05:14AM +0900, S.Sakamoto wrote: > Hi, > > "attach-disk" does not give an error, > when the domain which is attached has already used the source which attach. > This has danger of the data corruption. > > I make the patch to add the check of this. > This patch outputs an error, > when the domain which is attached has already used the source which attach. What hypervisor were you testing with ? AFAIR, XenD should already raise an appropriate error in this scenario. The libvirt QEMU driver, however, does need this checking. That should really be done in the qemu_driver.c attach method. Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list