On Thu, Oct 30, 2008 at 01:37:34PM +0000, Daniel P. Berrange wrote: > Following Daniel's feedback yesterday, instead of moving the virGetDomain > & related functions from hash.c into libvirt.c, I create a new file to > deal with all our public datatypes. I call it datatypes.h, datatypes.c I don't care too much about the name, datatypes.[ch] sounds good :-) > A bunch of stuff moves out of hash.c and internal.h into these two files. > Quite a few internal driver files need updates to add an extra #include > line. There should be no functional changes here [...] > --- a/po/POTFILES.in Wed Oct 29 20:09:50 2008 +0000 > +++ b/po/POTFILES.in Wed Oct 29 20:10:40 2008 +0000 > @@ -3,8 +3,8 @@ > qemud/remote.c > src/conf.c > src/console.c > +src/datatypes.c > src/domain_conf.c > -src/hash.c > src/iptables.c > src/libvirt.c Hum, this means I should push the .pot file soonish after the patches are applied Patch looks fine, +1 Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/ -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list