Hi, Shigeki At first, libvirt.c should not check VMM-arch specific value. In this meaning, xs_internal.c do the right thing. The problem is error handling on libvirt.c(Xen Store error is not handled properly). Do you investigate it? Thanks Atsushi SAKAI "S.Sakamoto" <fj0588di@xxxxxxxxxxxxxxxxx> wrote: > Hi, > > I have a question. > Why does libvirt check size of memory in xenStoreDomainSetMemory of xs_internal.c? > > In the xen not exclude lifecycle, > when I do the following command for the domain that is shutoff, > error message is output and return value is 0 and the definition file(=/etc/xen/XXX) is updated. > > -------------------- > # virsh setmem(or setmaxmem) guestdom 65535(4096-65535) > libvir: Xen Store error : invalid argument in xenStoreDomainSetMemory > > # echo $? > 0 > -------------------- > > As a result that I research this, > this error message is output by the check of the memory size in xenStoreDriver. > Because libvirt checks the memory size of under 4096 in libvirt.c, > I think that libvirt should check memory size range of 4096-65535 in libvirt.c. > > > Thanks, > Shigeki Sakamoto. > > -- > Libvir-list mailing list > Libvir-list@xxxxxxxxxx > https://www.redhat.com/mailman/listinfo/libvir-list -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list