On Wed, Oct 29, 2008 at 02:19:57PM -0400, Cole Robinson wrote: > Daniel Veillard wrote: > > On Wed, Oct 22, 2008 at 03:25:21PM -0400, Cole Robinson wrote: > >> The attached patch implements the storage driver routines > >> for the test driver. Most of the code is identical to > >> storage_driver.c with all the references to backends > >> removed. > >> > >> One caveat of this is that storage pools are hardcoded > >> to a specific size when they are defined: I figure someone > >> could expand this to read sizes from xml at definition > >> time if they wanted, but for now hardcoded values is > >> sufficient. > >> > >> I've done some decent testing with it all, so I'm pretty > >> confident it isn't too broken. > > > > Looks good. Maybe it would be worth adding (but where) > > in the test tree some example of the test XML definitions > > you used. > > > > A 'test of the test suite' certainly would be useful, > more so now that the xml parsing is unified. > > I've been exercising this patch via some unit tests > against virtinst's storage xml building routines. I > could take some of the generated output from that > and use it directly in the libvirt tests, though I > think that can come later. The intent was that we'd exercise the 'test' driver via the virsh test suite. Basically we should extend virshtest to cover more of the virsh commands, and this would automatically give us coverage of alot of the test driver as a side effect Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list