On Wed, Oct 29, 2008 at 11:34:44AM +0000, Daniel P. Berrange wrote: > Chris' recent patch removed use of the virStringList for the LVM discovery, > but it was still used in the NFS discovery code. I figured we might as well > make NFS discovery use virStoragePoolSourceList() too. This require a few > changes: > > - Include pool type in virStoragePoolSourceList so XML formatter knows > what type of source information is available > - Factor out code to format a single virStoragePoolSourcePtr object > into a virStoragePoolSourceFormat method > - Make virStoragePoolDefFormat & virStoragePoolListFormat both call > this common method > - Make LVM discovery code set the pool type in source list > - Switch NFS discovery to use virStoragePoolSourceList Looks fine to me. Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/ -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list