On Tue, Oct 21, 2008 at 02:42:40PM +0100, Daniel P. Berrange wrote: [..snip..] > Is there not some 'info pci' or 'info disk' command we cna use to find > out the PCI slot number at the time we want to detach the device. This > would make it work for all disks, and avoid the need to track the > state in that virDomainDiskDef union I don't like restricting this to hot added disks either but for one this will probably be a very common suitation and more important qemu just doesn't give enough information to do this reliably. The only really reliable way would (at least I think) be for the user (in this case libvirt) to pass a token to qemu (with -drive and with pci_add). We should then be able to detach using this token. Something else will always be dependent on what hardware qemu currently emulates. This would need to be implemented in qemu for usb and pci. -- Guido -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list