On Thu, Oct 16, 2008 at 03:15:08PM +0200, Daniel Veillard wrote: > As the number of compilation options and platform grows, it gets > more difficult for a commiter to always ensure one chunk of code > won't give a problem in a different situation. To try to lower the > cost of maintaining the protability I would suggest the following > rule for commit: > - if a recently commited patch breaks compilation on a platform > or for a given driver then it's fine to commit a minimal fix > directly without getting the review feedback first > - similary if make check or make syntax-chek breaks, if there is > an obvious fix, it's fine to commit immediately > Note that this would remove the need to send the patch to the list would *not* .... sigh ! > anyway (or tell what the fix was if trivial). This doesn't either > remove the rule that 'make check syntax-check' should pass before Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/ -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list