On Thu, Oct 16, 2008 at 09:43:58AM +0200, Chris Lalancette wrote: > To keep code duplication down, I moved some of the enum's from > storage_backend_disk.c into a common place. Note, however, that there is a > slight semantic change because of this. Previously, if no label was found on a > disk in storage_backend_disk.c, it would always return "dos" as the label type. > That's not actually true, though; if it's a completely zeroed disk, for > instance, it really just has label type of 'unknown'. This patch changes to the > new semantic of 'unknown' for label types we don't understand. I don't think > this will be a huge issue for compatibility, but there could be something I'm > missing. I don't see a compatability problem - existing behaviour is a clear bug. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list