"Daniel P. Berrange" <berrange@xxxxxxxxxx> wrote: > On Fri, Oct 10, 2008 at 11:47:49AM +0200, Jim Meyering wrote: >> Daniel Veillard <veillard@xxxxxxxxxx> wrote: >> >> > On Thu, Oct 09, 2008 at 11:44:02AM -0400, Cole Robinson wrote: >> >> Daniel Veillard wrote: >> >> > On Wed, Oct 08, 2008 at 08:35:38PM +0100, Daniel P. Berrange wrote: >> > >> > Hum, this breaks "make check" >> > >> > PASS: read-non-seekable >> > --- out 2008-10-10 10:23:57.000000000 +0200 >> > +++ exp 2008-10-10 10:23:57.000000000 +0200 >> > @@ -1,2 +1,2 @@ >> > -libvir: Test error : internal error Domain is still running >> > +libvir: Test error test: internal error Domain is still running >> > error: Failed to undefine domain test >> > FAIL: undefine >> > >> > Seems we loose the domain name in the error message when trying to >> > undefine a running domain: >> > >> > paphio:~/libvirt/tests -> /usr/bin/virsh -q -c test:///default undefine >> > test >> > libvir: Test error test: internal error Domain is still running >> > error: Failed to undefine domain test >> > paphio:~/libvirt/tests -> ../src/virsh -q -c test:///default undefine >> > test >> > libvir: Test error : internal error Domain is still running >> > error: Failed to undefine domain test >> > paphio:~/libvirt/tests -> >> > >> > I should be possible to restore the old behaviour of reporting the domain >> > name there >> >> The documentation suggests that the new interface was initially >> supposed to have dom and net parameters: > > We removed them because they're deprecated and 90% of the driver code > never provides them - the test driver was the exception to the rule here Oh well. FYI, the other exceptions: lxc_conf.h: lxcError (dom-only) qemu_conf.h: qemudReportError ... > That's not really solving the problem because very little code passes > in a non-NULL dom/net parameter. -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list