On Mon, Oct 06, 2008 at 04:04:43PM +0100, Daniel P. Berrange wrote: > > But each driver still need to access those structures directly, > > with the future goal of having driver loaded as shared lib modules > > maybe that interface should be defined as a few entry points to > > add, remove, lookup and iterate (with a callback). The refactoring > > here might be a good opportunity to hide the implementation from > > driver code. Opinion ? > > This won't really gain us anything from point of view of thread safety, > and I don't think it magically solves any compatability issues wrt to > loadable drivers. > > This is another topic entirely, but when we do have loadable modules, > my feeling is to require that they all be built in-tree, and not allow > (potentially closed-source) out of tree modules. If we mandate that > they're in tree then there's no ABI compatability to worry about. Well if you're afraid of closed source modules that won't be possible because in the end it's the daemon which loads them and as we have noticed it will end up being GPLed since we will link some GPL bits like the Hal library in the daemon. Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/ -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list