On Fri, Oct 03, 2008 at 08:45:00AM -0700, Dan Smith wrote: > DB> This list of devices is currently duplicated in two places - once > DB> here where we set permissions, and again when we actually create > DB> the container and populate its /dev/ in lxc_container.c. Could do > DB> with a master list of device nodes used by both. > > So does that mean they should be somewhere other than cgroup.h? I'd think lxc_config.h or lcx_container.h would be a more natural place for the constants, since both the .c files which would use them as lxc_XXXX driver files. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list