Re: [libvirt] [PATCH 2 of 2] Use cgroup functions to set resource limits on LXC domains

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



DB> Should use lxcError() here - as things are setup by virExec(),
DB> calls to lxcError() call to virRaiseError() which ultimately calls
DB> fprintf(). By using lxcError() can we more easily change logging
DB> later if needed.

Indeed.

DB> I think we need to virCgroupRemove() in the error path to cleanup
DB> a partially constructed cgroup ?

Yep, I'll fix that too.

Thanks!

-- 
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms@xxxxxxxxxx

Attachment: pgp4I107cEMZw.pgp
Description: PGP signature

--
Libvir-list mailing list
Libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]