This patch just cleans up the virStorageDriver structs so that they use the
.functionPointer = functionname syntax of gcc. This makes it much easier to
grep in the code later. This patch also re-arranges the order of the function
pointers in remote_internal so that it matches the definition of
virStorageDriver in src/driver.h. While not strictly necessary, it does make it
a little more sane when looking at it in the future.
Signed-off-by: Chris Lalancette <clalance@xxxxxxxxxx>
Index: src/remote_internal.c
===================================================================
RCS file: /data/cvs/libvirt/src/remote_internal.c,v
retrieving revision 1.83
diff -u -r1.83 remote_internal.c
--- a/src/remote_internal.c 29 Aug 2008 07:11:15 -0000 1.83
+++ b/src/remote_internal.c 19 Sep 2008 08:17:23 -0000
@@ -4907,14 +4907,14 @@
.numOfDefinedPools = remoteNumOfDefinedStoragePools,
.listDefinedPools = remoteListDefinedStoragePools,
.findPoolSources = remoteFindStoragePoolSources,
- .poolLookupByUUID = remoteStoragePoolLookupByUUID,
.poolLookupByName = remoteStoragePoolLookupByName,
+ .poolLookupByUUID = remoteStoragePoolLookupByUUID,
.poolLookupByVolume = remoteStoragePoolLookupByVolume,
.poolCreateXML = remoteStoragePoolCreateXML,
.poolDefineXML = remoteStoragePoolDefineXML,
+ .poolBuild = remoteStoragePoolBuild,
.poolUndefine = remoteStoragePoolUndefine,
.poolCreate = remoteStoragePoolCreate,
- .poolBuild = remoteStoragePoolBuild,
.poolDestroy = remoteStoragePoolDestroy,
.poolDelete = remoteStoragePoolDelete,
.poolRefresh = remoteStoragePoolRefresh,
Index: src/storage_driver.c
===================================================================
RCS file: /data/cvs/libvirt/src/storage_driver.c,v
retrieving revision 1.9
diff -u -r1.9 storage_driver.c
--- a/src/storage_driver.c 27 Aug 2008 20:05:59 -0000 1.9
+++ b/src/storage_driver.c 19 Sep 2008 08:17:24 -0000
@@ -1229,39 +1229,40 @@
static virStorageDriver storageDriver = {
- "storage",
- storageOpen,
- storageClose,
- storageNumPools,
- storageListPools,
- storageNumDefinedPools,
- storageListDefinedPools,
- storageFindPoolSources,
- storagePoolLookupByName,
- storagePoolLookupByUUID,
- storagePoolLookupByVolume,
- storagePoolCreate,
- storagePoolDefine,
- storagePoolBuild,
- storagePoolUndefine,
- storagePoolStart,
- storagePoolDestroy,
- storagePoolDelete,
- storagePoolRefresh,
- storagePoolGetInfo,
- storagePoolDumpXML,
- storagePoolGetAutostart,
- storagePoolSetAutostart,
- storagePoolNumVolumes,
- storagePoolListVolumes,
- storageVolumeLookupByName,
- storageVolumeLookupByKey,
- storageVolumeLookupByPath,
- storageVolumeCreateXML,
- storageVolumeDelete,
- storageVolumeGetInfo,
- storageVolumeGetXMLDesc,
- storageVolumeGetPath
+ .name = "storage",
+ .open = storageOpen,
+ .close = storageClose,
+ .numOfPools = storageNumPools,
+ .listPools = storageListPools,
+ .numOfDefinedPools = storageNumDefinedPools,
+ .listDefinedPools = storageListDefinedPools,
+ .findPoolSources = storageFindPoolSources,
+ .poolLookupByName = storagePoolLookupByName,
+ .poolLookupByUUID = storagePoolLookupByUUID,
+ .poolLookupByVolume = storagePoolLookupByVolume,
+ .poolCreateXML = storagePoolCreate,
+ .poolDefineXML = storagePoolDefine,
+ .poolBuild = storagePoolBuild,
+ .poolUndefine = storagePoolUndefine,
+ .poolCreate = storagePoolStart,
+ .poolDestroy = storagePoolDestroy,
+ .poolDelete = storagePoolDelete,
+ .poolRefresh = storagePoolRefresh,
+ .poolGetInfo = storagePoolGetInfo,
+ .poolGetXMLDesc = storagePoolDumpXML,
+ .poolGetAutostart = storagePoolGetAutostart,
+ .poolSetAutostart = storagePoolSetAutostart,
+ .poolNumOfVolumes = storagePoolNumVolumes,
+ .poolListVolumes = storagePoolListVolumes,
+
+ .volLookupByName = storageVolumeLookupByName,
+ .volLookupByKey = storageVolumeLookupByKey,
+ .volLookupByPath = storageVolumeLookupByPath,
+ .volCreateXML = storageVolumeCreateXML,
+ .volDelete = storageVolumeDelete,
+ .volGetInfo = storageVolumeGetInfo,
+ .volGetXMLDesc = storageVolumeGetXMLDesc,
+ .volGetPath = storageVolumeGetPath,
};
--
Libvir-list mailing list
Libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list