On Mon, Sep 15, 2008 at 02:55:40PM -0400, Ben Guthro wrote: > Attached is a patch to add some additional options to the spec file, > allowing for more flexibility when building. > With this patch, it allows you to build a "client-only" version of > libvirt for machines that may have an interest in communicating over the > remote driver, but do not have a hypervisor themselves. While in general I think this is useful, I don't see the point in the disabling of the -devel sub-RPM. This doesn't impact anything at compile time, and if you don't want it post-build, then simply don't distribute it. The -devel could still be useful for a client only version, if people want to build client apps. As it is the extra conditionals for disabling -devel just clutter the spec file more without any obvious advantage. I'd ACK something without the -devel conditionals. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list