On Fri, Aug 29, 2008 at 03:39:44PM +0200, Daniel Veillard wrote: > > +/* For virConnectListAllDomains. */ > > +#define VIR_DOMAIN_LIST_NOSTATE (1 << VIR_DOMAIN_NOSTATE) > > +#define VIR_DOMAIN_LIST_RUNNING (1 << VIR_DOMAIN_RUNNING) > > +#define VIR_DOMAIN_LIST_BLOCKED (1 << VIR_DOMAIN_BLOCKED) > > +#define VIR_DOMAIN_LIST_PAUSED (1 << VIR_DOMAIN_PAUSED) > > +#define VIR_DOMAIN_LIST_SHUTDOWN (1 << VIR_DOMAIN_SHUTDOWN) > > +#define VIR_DOMAIN_LIST_SHUTOFF (1 << VIR_DOMAIN_SHUTOFF) > > +#define VIR_DOMAIN_LIST_CRASHED (1 << VIR_DOMAIN_CRASHED) > > + > > +#define VIR_DOMAIN_LIST_ACTIVE (VIR_DOMAIN_LIST_NOSTATE | \ > > + VIR_DOMAIN_LIST_RUNNING | \ > > + VIR_DOMAIN_LIST_BLOCKED | \ > > + VIR_DOMAIN_LIST_PAUSED | \ > > + VIR_DOMAIN_LIST_SHUTDOWN | \ > > + VIR_DOMAIN_LIST_CRASHED) > > +#define VIR_DOMAIN_LIST_INACTIVE VIR_DOMAIN_LIST_SHUTOFF > > +#define VIR_DOMAIN_LIST_ALL (VIR_DOMAIN_LIST_ACTIVE | VIR_DOMAIN_LIST_INACTIVE) > > Hum ... I wonder if basing the selection on status like that may > not generate compatibility problems in the future if we add a new > state for some hypervisor. i'm not sure defining ACTIVE/ALL/INACTIVE > in term of union will really help in the long term. You mean this as an ABI concern? We could certainly give the ACTIVE/ALL/INACTIVE flags extra magic values if you think that would help. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list