On Fri, Aug 29, 2008 at 02:30:55PM +0100, Richard W.M. Jones wrote: > On Fri, Aug 29, 2008 at 02:26:47PM +0100, Daniel P. Berrange wrote: > > The compatability code requires that you get all virDomainInfo objects > > to filter by state, but a native implementation in the various drivers > > will not neccessarily require this to be done. I agree we should > > have the 'infos' parameter in the public API, it should be allowed > > to be NULL though. > > OK, I'll change it so that infos can be NULL (but not domains). > Mainly this will involve changing the remote code. > > > Fetching the info for QEMU guests is not entirely > > without costs of its own - read & parse several /proc/ files per > > VM, and filtering can be done without this, since QEMU tracks the state > > flag in libvirtd explicitly. > > Yes, I missed the fact that qemuDomainGetInfo has to call out to get > process information. I thought it just got everything from the vm > structure. > > > I'd like to see an implementation of this working against XenD before > > we commit this to API, since that's the driver which stands to gain > > the most from the performance improvements this API ought to allow. > > OK, I don't have a way to test Xen right now. I was hoping I could > implement it for QEMU first. If you have code that at least compiles, I can debug/test it - I've got various Xen versions running in KVM guests :-) Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list