On Fri, 2008-08-22 at 09:50 +0100, Daniel P. Berrange wrote: > > + const char *start_tag = "<SourceList>\n"; > > + const char *end_tag = "</SourceList>\n"; > > I'd prefer that to be <sources> - we avoid capitals in the > XML element names everywhere else, and in the few cases of > joining words use an underscore, but I think plural form is > OK for this. I prefer <sources> as well, so I'll change this. And I'll put those defines in storage_backend.h as well. As long as we're on the subject of naming (and before it's too late), it's been bothering me that we keep calling this "storage pool discovery". To me, "storage source discovery" seems more accurate (because they're not pools until we define libvirt pools based on the sources). So I'd prefer renaming the various *Discover[Storage]Pools* functions (and support structs) introduced in this patch to *Discover[Storage]Sources*. I was just sticking with the originally-proposed names to avoid confusion. What do you all think? Dave -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list