Daniel P. Berrange wrote: > On Fri, Aug 22, 2008 at 09:26:13AM +0100, Richard W.M. Jones wrote: > >> On Thu, Aug 21, 2008 at 11:19:29PM -0400, Cole Robinson wrote: >> >>> The virsh attach-* and detach-* commands don't say >>> anything if the operation succeeds, which doesn't >>> seem very polite. The attached adds some simple >>> feedback. >>> >> Hmmm ... The patch is fine, but I don't really like commands which >> are verbose on anything other than errors. >> > > Nor do I, but all our other commands print a confirmation message > too, so for sake of consistency I think Cole's patch is reasonable. > We do have a --quiet arg to make it STFU > That was my reasoning as well. When commands like 'start' and 'define' report success but attach-device doesn't, I was left wondering if it even worked. - Cole -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list