On Tue, Aug 12, 2008 at 07:18:00PM +0200, Jim Meyering wrote: > I've rewritten virFileLinkPointsTo to be a lot simpler, > and more importantly, it has far fewer failure points. > If anyone wants to preserve the original behavior that > makes it fail when the first parameter does not specify > a symlink, I can add that. The only difference in behavior > would be when the two files are hard-linked. Nah, that's not a difference we'd encounter with the way we use this API inside libvirt. > In any case, I'll remove the FIXME comment. Remove the virLog() function too - the caller should be responsible for reporting errors / logging if it so desires. Aside from that, ACK - this is a very nice simplification. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list