On Mon, Aug 11, 2008 at 03:58:41PM -0400, Cole Robinson wrote: > The patch below implements virStorageVolDelete for volumes > on a disk pool. > > The only interesting thing here is that parted wants a > partition number to delete, so we need to peel off the > end of the volume's target path which will be of the form > '/dev/sda1' or similar (I assume. If not, it's still > better than having nothing implemented). Without much understanding of the storage command, I will say the patch looks fine to me, but I would prefer another review :-) Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@xxxxxxxxxx | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/ -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list