On Mon, Aug 11, 2008 at 03:58:55PM -0400, Cole Robinson wrote: > In the python bindings, all vir* classes expect to be > passed a virConnect object when instantiated. Before > the storage stuff, these classes were only instantiated > in virConnect methods, so the generator is hardcoded to > pass 'self' as the connection instance to these classes. > > Problem is there are some methods that return pool or vol > instances which aren't called from virConnect: you can > lookup a storage volume's associated pool, and can lookup > volumes from a pool. In these cases passing 'self' doesn't > give the vir* instance a connection, so when it comes time > to raise an exception crap hits the fan. > > Rather than rework the generator to accomodate this edge > case, I just fixed the init functions for virStorage* to > pull the associated connection out of the passed value > if it's not a virConnect instance. Okay, I understand, it's a bit funky to check the class but that should work. Applied and commited, thanks ! Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@xxxxxxxxxx | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/ -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list