"Daniel P. Berrange" <berrange@xxxxxxxxxx> wrote: > The lxc_driver.c file contains quite a large amount of code, > serving two reasonably well separated purposes. First there > is the direct implemntation of each of the libvirt driver > APIs. Second there is the code to spawn a container and a > controller for forwarding I/O to/from the PTYs. This patch > attempts to re-arrange the code across files to better reflect > the split in functionality. The general idea is thus: > > - lxc_driver.c: implementation of the libvirt driver APIs > - lxc_container.c: code for creating containers > - lxc_controller.c: code for managing an active container > > So this entails the following re-arrangement: Most changes were straight function copies. In the few cases where there were nontrivial changes, they looked fine, though it was tedious to extract the diffs. I liked the s/0/false/ and s/1/true/ changes. It'd be nice to make more use of the "bool" type in libvirt. ACK -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list