Jim Meyering <jim@xxxxxxxxxxxx> wrote: > Jim Meyering <jim@xxxxxxxxxxxx> wrote: >> Maybe you're talking about something else? >> I proposed to add a trailing newline in the expected output >> as well as in the code to generate the "actual" output. >> >> This is the sort of change I was thinking of: >> >> diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c > > At first I thought that might be incomplete. > But it's all that's needed on the C side. > I ran this one-liner to append the missing newlines, and we're all set: > > for i in $(find|grep '\.args$'); do echo >> $i;done > > "make check" and "make syntax-check" both pass. Planning to commit that, I rebased against the latest, but found "make check" then failed due to three new expected-output ".args" files without the now-required trailing newline. I added them, and now "make check" passes, so I've just committed it. -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list