Jim Meyering wrote: >> On Fri, Aug 08, 2008 at 02:07:49PM +0200, Jim Meyering wrote: >>> Guido Günther <agx@xxxxxxxxxxx> wrote: >>>> >From a714b14a13f97b824c288fc40165ef9fe5fbaae0 Mon Sep 17 00:00:00 2001 >>>> From: Guido Guenther <agx@xxxxxxxxxxx> > ... >>> Please add a newline and split the long line: >>> >>> /usr/bin/qemu -S -M pc -m 214 -smp 1 -nographic -monitor pty -no-acpi \ >>> -boot c -hda /dev/HostVG/QEMUGuest1 -usbdevice disk:/tmp/usbdisk.img \ >>> -net none -serial none -parallel none -usb >> No, this would break the test case, since its being compared against >> generated data in the format shown by the patch. > > Ahh... it looked like something to be executed (and maintained), > rather than merely expected output. So no need to split long lines. > > However, including a trailing newline might be worthwhile > (and adjust the code to emit the matching newline), since some editors > have a hard time modifying or creating a file with no newline at EOF. Heh. Unfortunately, that's not an option either. The tests just do a simple strcmp(), so if there is an extra trailing newline in the args file, the test will "fail". I ran into this before. Chris Lalancette -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list