On Fri, Aug 08, 2008 at 02:07:49PM +0200, Jim Meyering wrote: > Guido Günther <agx@xxxxxxxxxxx> wrote: > >>From a714b14a13f97b824c288fc40165ef9fe5fbaae0 Mon Sep 17 00:00:00 2001 > > From: Guido Guenther <agx@xxxxxxxxxxx> > > Date: Thu, 7 Aug 2008 14:39:35 +0200 > > Subject: [PATCH] usbmass: testcase for file as src for usb disk > ... > > diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-usb.args b/tests/qemuxml2argvdata/qemuxml2argv-disk-usb.args > > new file mode 100644 > > index 0000000..60a8317 > > --- /dev/null > > +++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-usb.args > > @@ -0,0 +1 @@ > > +/usr/bin/qemu -S -M pc -m 214 -smp 1 -nographic -monitor pty -no-acpi -boot c -hda /dev/HostVG/QEMUGuest1 -usbdevice disk:/tmp/usbdisk.img -net none -serial none -parallel none -usb > > \ No newline at end of file > > Please add a newline and split the long line: > > /usr/bin/qemu -S -M pc -m 214 -smp 1 -nographic -monitor pty -no-acpi \ > -boot c -hda /dev/HostVG/QEMUGuest1 -usbdevice disk:/tmp/usbdisk.img \ > -net none -serial none -parallel none -usb No, this would break the test case, since its being compared against generated data in the format shown by the patch. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list