On Tue, Aug 05, 2008 at 12:02:47PM +0200, Chris Lalancette wrote:
> With the recent refactoring of the domain code, plus the changes with the Xend
> code, a couple of bugs were introduced into the attach-disk and attach-interface
> functionality. This patch fixes 3 bugs:
>
> 1) In xenDaemonAttachDevice(), there is a switch statement to determine which
> of the xenDaemonFormatSxpr{Disk,Net} functions to call. Unfortunately, the case
> statements are all missing the corresponding "break", so we always fall-through
> to the default error case. This patch just adds the appropriate break statements.
>
> 2) (minor) In xenDaemonDomainDefineXML (that's a mouthful!), there is a stray
> "fprintf". This is now converted to a proper virXendError().
>
> 3) xenDaemonFormatSxpr{Disk,Net} were adding an extra (device to the front of
> the sexpr expressions that xend did not expect (this is Xend on RHEL 5.2).
> Because of this, the attaches would fail. The patch fixes this by removing the
> (device from the front, which makes attach-disk and attach-interface work again.
>
> Signed-off-by: Chris Lalancette <clalance@xxxxxxxxxx>
1/ and 2/ are obvious errors, for 3/ I guess it's not dependent on the
Xen version so I think it's fine.
+1
thanks !
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard@xxxxxxxxxx | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
--
Libvir-list mailing list
Libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list