On Wed, Jul 30, 2008 at 10:17:59AM +0100, Daniel P. Berrange wrote: > Forwarding message that was sent to wrong list... Hum, that sounds right, the logic got twisted, the presence of a defined port should otherride the autoport settings, right ? Daniel > > case VIR_DOMAIN_GRAPHICS_TYPE_VNC: > > - if (def->data.vnc.autoport) > > - virBufferAddLit(buf, " port='-1'"); > > - else if (def->data.vnc.port) > > + if (def->data.vnc.port) > > virBufferVSprintf(buf, " port='%d'", > > def->data.vnc.port); > > + else if (def->data.vnc.autoport) > > + virBufferAddLit(buf, " port='-1'"); > > -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@xxxxxxxxxx | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/ -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list