On Fri, Jul 18, 2008 at 06:29:15PM +0200, Jim Meyering wrote: > > Looks like this can be replaced with virDomainChrTypeFromString. > > > + if (STREQ(type, "null")) > > + def->type = VIR_DOMAIN_CHR_TYPE_NULL; > > + else if (STREQ(type, "vc")) > > + def->type = VIR_DOMAIN_CHR_TYPE_VC; > > + else if (STREQ(type, "pty")) > > + def->type = VIR_DOMAIN_CHR_TYPE_PTY; > > + else if (STREQ(type, "dev")) > > + def->type = VIR_DOMAIN_CHR_TYPE_DEV; > > + else if (STREQ(type, "file")) > > + def->type = VIR_DOMAIN_CHR_TYPE_FILE; > > + else if (STREQ(type, "pipe")) > > + def->type = VIR_DOMAIN_CHR_TYPE_PIPE; > > + else if (STREQ(type, "stdio")) > > + def->type = VIR_DOMAIN_CHR_TYPE_STDIO; > > + else if (STREQ(type, "udp")) > > + def->type = VIR_DOMAIN_CHR_TYPE_UDP; > > + else if (STREQ(type, "tcp")) > > + def->type = VIR_DOMAIN_CHR_TYPE_TCP; > > + else if (STREQ(type, "unix")) > > + def->type = VIR_DOMAIN_CHR_TYPE_UNIX; > > + else > > + def->type = VIR_DOMAIN_CHR_TYPE_NULL; > > + } Good point, i'll fix this in CVS Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list