On Sat, Jul 05, 2008 at 04:43:04PM +0100, John Levon wrote: > > The below patch makes a significant update to libvirt.rng to bring it > into line with reality. This is an incremental improvement rather than a > full fix. In particular, various parts are still under-specified (e.g. > qemu char devices). > > This version lets almost all of the XML files in tests/ validate. I'd > appreciate help getting the last few to validate - any volunteers? Sure - what command are you using to validate ? > One possible idea might be virsh validate: split out both the schema > validation and the additional checks in libvirt into one consolidated > place. This would help people check their definitions. > > The question also arises on how to help avoid the schema getting so > badly out of date again. Some suggestions: > > - add a validation phase to the test suite, and mark failures This is a good idea. > - require any changes to the implicit schema to add a test suite entry All XML additions should require test suite support, so if we have validation on all test suite data files this should ensure it is essentially compulsory. [snip the schema] All your changes look good to me. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list