"Daniel P. Berrange" <berrange@xxxxxxxxxx> wrote:
...
cont'd
> static int testNetworkUndefine(virNetworkPtr network) {
...
> static char *testNetworkGetBridgeName(virNetworkPtr network) {
> char *bridge;
> GET_NETWORK(network, NULL);
> - bridge = strdup(privnet->bridge);
> + bridge = privnet->def->bridge ? strdup(privnet->def->bridge) : NULL;
> if (!bridge) {
> testError(network->conn, NULL, network, VIR_ERR_NO_MEMORY, "network");
> return NULL;
This change makes it so a NULL privnet->def->bridge will
mistakenly provoke an out of memory error.
--
Libvir-list mailing list
Libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list