On Thu, Jun 19, 2008 at 01:56:11PM +0200, Jim Meyering wrote:
> Chris Lalancette <clalance@xxxxxxxxxx> wrote:
> > Jim Meyering wrote:
> >> diff --git a/src/util.c b/src/util.c
> >> index ad7683d..5e50ef2 100644
> >> --- a/src/util.c
> >> +++ b/src/util.c
> >> @@ -306,7 +306,7 @@ fread_file_lim (FILE *stream, size_t max_len, size_t *length)
> >> if (alloc < size + BUFSIZ + 1)
> >> alloc = size + BUFSIZ + 1;
> >>
> >> - if (VIR_ALLOC_N(buf, alloc) < 0) {
> >> + if (VIR_REALLOC_N(buf, alloc) < 0) {
> >> save_errno = errno;
> >> break;
> >> }
> >> @@ -797,4 +797,3 @@ int virDiskNameToIndex(const char *name) {
> >>
> >> return idx;
> >> }
> >
> > Yep. Good catch. Confirmed by following your test procedure, and confirmed
> > that this fixes the issue.
> >
> > ACK
>
> Thanks for the quick review.
> I've gone ahead and added a small test script to exercise the bug,
> so the following is what I now expect to commit.
yes please !
+1
thanks !
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard@xxxxxxxxxx | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
--
Libvir-list mailing list
Libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list