[libvirt] Fix qemudParseVMDeviceDef() to check for proper network device tag name

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Is it too late to get this change in?

Instead of "net", the tag name should be "interface". Previously, attempting to attach a network device to a KVM guest would return:

libvir: QEMU error : XML description for unknown device type is not well formed or invalid
error: Failed to attach device from attach-disk.xml

With this fix, it returns:

libvir: QEMU error test_domain: this function is not supported by the hypervisor: only CDROM disk devices can be attached libvir: QEMU error : this function is not supported by the hypervisor: only CDROM disk devices can be attached
error: Failed to attach device from attach-disk.xml


Index: src/qemu_conf.c
===================================================================
RCS file: /data/cvs/libvirt/src/qemu_conf.c,v
retrieving revision 1.77
diff -u -p -r1.77 qemu_conf.c
--- src/qemu_conf.c     12 Jun 2008 10:19:24 -0000      1.77
+++ src/qemu_conf.c     12 Jun 2008 16:17:59 -0000
@@ -2964,7 +2964,7 @@ qemudParseVMDeviceDef(virConnectPtr conn
     if (xmlStrEqual(node->name, BAD_CAST "disk")) {
         dev->type = QEMUD_DEVICE_DISK;
         qemudParseDiskXML(conn, &(dev->data.disk), node);
-    } else if (xmlStrEqual(node->name, BAD_CAST "net")) {
+    } else if (xmlStrEqual(node->name, BAD_CAST "interface")) {
         dev->type = QEMUD_DEVICE_NET;
         qemudParseInterfaceXML(conn, &(dev->data.net), node);
     } else if (xmlStrEqual(node->name, BAD_CAST "input")) {

--
Kaitlin Rupert
IBM Linux Technology Center
kaitlin@xxxxxxxxxxxxxxxxxx

--
Libvir-list mailing list
Libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]