On Thu, Jun 05, 2008 at 02:08:41PM -0400, Cole Robinson wrote: > The attached patch fixes a few issues in the python bindings. > > First, UUIDString has, to my understanding, never worked. It expected > to be passed a buffer to fill with the uuid, which through my tests > isn't realistically doable from python. I added custom bindings to > fix this, and it now works as expected, taking no arguments and > returning a string. > > UUID for a storage pool wasn't being generated with its custom function, > so it too was broken. This is also fixed. > > I also removed some stale entries for virStorageVol UUID functions > from generator.py which were probably just carried along from an old > version of the storage api patches (storage volumes don't use UUID). Looks fine to me, applied and commited, thanks ! Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@xxxxxxxxxx | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/ -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list