On Fri, May 30, 2008 at 04:31:14PM -0700, Dave Leskovec wrote: > Daniel Veillard wrote: > > On Thu, May 29, 2008 at 03:44:24PM -0700, Dave Leskovec wrote: > ... > > > > Hum, I'm surprized the PID file is removed only in lxcDomainUndefine. > > The PID file need to be re-created each time the domain is started. But > > a domain could be started and stopped many time while being defined, > > what happen in a (define/start/stop/start) sequence ? Looks to me the > > O_CREAT flag in the second start would break because the PID file is still > > here ... > > > > Maybe I'm just wrong but if you could just double check that scenario before > > the commit, that would be nice :-) > > > > Daniel > > > > O_CREAT just causes the file to be created if it doesn't exist. O_EXCL will > trigger an error if the file already exists. Oops, right :-), wrong flag ! > I'd considered removing it after killing the tty process but don't recall now > why I didn't do that. I think it makes sense to do that so I'll make the change > with the ones from Jim and Dan. Cool, thanks ! Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@xxxxxxxxxx | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/ -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list