On Thu, May 22, 2008 at 10:54:35AM +0200, Jim Meyering wrote: > "Daniel P. Berrange" <berrange@xxxxxxxxxx> wrote: > > As suggested by Jim, this patch goes through the configure script and makes > > sure all args to macros are fully quoted. NB, this applies on top of the > > NUMA/cpu pinning patches I sent the other day, not CVS. > ... > > Looks fine. Thanks for doing that! > I confirmed that your change induces no change in configure. > > > - AC_PATH_PROG(MOUNT, [mount], [], [$PATH:/sbin:/usr/sbin]) > > - AC_PATH_PROG(UMOUNT, [umount], [], [$PATH:/sbin:/usr/sbin]) > > + AC_PATH_PROG([MOUNT], [mount], [], [$PATH:/sbin:/usr/sbin]) > > + AC_PATH_PROG([UMOUNT], [umount], [], [$PATH:/sbin:/usr/sbin]) > > if test "$with_storage_fs" = "yes" ; then > > if test -z "$MOUNT" ; then AC_MSG_ERROR(We need mount for FS storage driver) ; fi > > if test -z "$UMOUNT" ; then AC_MSG_ERROR(We need mount for FS storage driver) ; fi > > BTW, I noticed a typo in context: that latter message should say "umount". > > Also, in your numactl patch, you can remove the " for security" bit: > > + AC_DEFINE_UNQUOTED([HAVE_NUMACTL], 1, [whether Numactl is available for security]) > > Re autoconf quoting, you can quote a few AC_MSG_ERROR arguments > like the two above. Here's a patch that does a few more, including > each AC_HELP_STRING use. You're welcome to apply it on top of yours. Thanks, will do that. Dan. -- |: Red Hat, Engineering, Boston -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list