On Mon, Apr 28, 2008 at 01:46:28PM -0400, Cole Robinson wrote: [...] Fine except: > - if (!strcmp(type, "qemu")) > + if (!strcasecmp(type, "qemu")) > return 16; > > /* XXX future KVM will support SMP. Need to probe > kernel to figure out KVM module version i guess */ > - if (!strcmp(type, "kvm")) > + if (!strcasecmp(type, "kvm")) > return 1; > > - if (!strcmp(type, "kqemu")) > + if (!strcasecmp(type, "kqemu")) > return 1; Can you change these equality tests to use the STR* macros from src/internal.h before committing. Thanks, Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list