On Thu, Apr 10, 2008 at 10:27:19AM +0100, Richard W.M. Jones wrote: > On Thu, Apr 10, 2008 at 10:53:44AM +0200, Jim Meyering wrote: > > Daniel Veillard <veillard@xxxxxxxxxx> wrote: > > > On Thu, Apr 10, 2008 at 08:42:08AM +0100, Richard W.M. Jones wrote: > > >> I also say you should go for the full patch. > > > > > > But please keep tabks in ChangeLog for indenting, > > > > Of course ;-) > > There's actually a "make syntax-check" that would barf if I tried > > expanding *those* TABs. > > > > It's in Makefile.maint, and I see that it's disabled > > because I added sc_changelog to the list of excluded checks > > in Makefile.cfg. I disabled it because the check requires > > ChangeLog date/author lines like this: > > > > 2008-04-08 Daniel Veillard <veillard@xxxxxxxxxx> > > > > rather than the ones we use: > > > > Tue Apr 8 18:14:50 CET 2008 Daniel Veillard <veillard@xxxxxxxxxx> > > The former are the style which emacs changelog mode uses, so switching > over would be useful (for me). current is :r!date for me in vi, the fingers type it by themselves without even asking the brain, that would be painful to change. Also i like the idea of having a more precise time, really, it's not like we do one commit every few days... Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@xxxxxxxxxx | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/ -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list