"Daniel P. Berrange" <berrange@xxxxxxxxxx> wrote: > On Wed, Apr 09, 2008 at 02:40:13PM +0100, Richard W.M. Jones wrote: >> On Wed, Apr 09, 2008 at 02:43:22PM +0200, Jim Meyering wrote: >> > Please don't add the "tab-width: 4" specifier. >> > Specifying a tab-width at all in a new file with "indent-tabs-mode: nil" >> > is a contradiction. The latter says there should be no TABs, yet >> > the former says "when there are, give them width 4." Coding style >> > guidelines are universal in their recommendations to stick with 8-byte >> > TAB stops, independent of whether you actually use TAB or spaces. >> >> Agreed, good idea. > > ACK. > > Could we get a make syntax-check test to look for these bogus tabs too Of course. These days, any time I make a global change like this, I also make time to ensure that new violations can't sneak back in. -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list