On Wed, Apr 09, 2008 at 11:52:07AM +0100, Richard W.M. Jones wrote: > On Tue, Apr 08, 2008 at 01:06:12PM -0700, Ryan Scott wrote: > > When a user runs 'virsh detach-disk' on a running domain, the disk is > > removed, but reappears after the domain is rebooted. This seems odd, as > > someone who types detach-disk most likely wants the change to be permanent. > > Actually I wonder what the expectation is. > > The QEMU driver only implements a very limited form of the > virDomainAttachDevice call (merely allowing you to signal that the > CD-ROM has been replaced) and doesn't implement virDomainDetachDevice > at all, so there is no example to go on there. > > Maybe better to document what the behaviour is supposed to be in > src/libvirt.c? After all you can effect a permanent change to the > device configuration by using virDomainDefineXML. Please think of the poor user. Dumping the XML, editing it by hand, and feeding it back in barely a user interface at all. virsh detach-disk is. (And yes, I would expect detach-disk to do exactly that, permanently.) regards john -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list